New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: early return if path is already absolute #3

Merged

peterjaap merged 2 commits into elgentos:master from iMi-digital:fix/relative-to-absolute-file-path-conversion

Mar 25, 2022

Contributor

DanieliMi commented Mar 25, 2022 •

edited

Loading

Fixes #2.

Converts the file path to a relative path based on the selectedMagento2ProjectDir for the link to open the file
Converts the file path to a absolute path based on the selectedMagento2ProjectDir for getting file contents

DanieliMi added 2 commits

March 25, 2022 12:46


          fix: early return if path is already absolute

3d121f5

Fixes elgentos#2.


          fix: convert to relative path based on selectedMagento2ProjectDir

1c702c0

Includes renaming fixPath to clarify what it does.

DanieliMi marked this pull request as ready for review

March 25, 2022 14:30

peterjaap merged commit 2c7fe08 into elgentos:master

Contributor

peterjaap commented Mar 25, 2022

Thanks!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet